Repository navigation
Conversation
phpGH-22063 prevents stream_filter_remove() from modifying a filter chain while it is being applied, rejecting removal with a warning instead. The pre-existing zlib.inflate regression test still expects successful filter removal from inside its error handler, so it now fails across multiple CI platforms on the unmodified PHP-8.4 branch. Update the expected output to assert the new warning and false result. Only the PHPT test is changed; this does not alter runtime behavior. Follow-up to php#22083.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-22063 prevents stream_filter_remove() from modifying a filter chain while it is being applied, rejecting removal with a warning instead. The pre-existing zlib.inflate regression test still expects successful filter removal from inside its error handler, so it now fails across multiple CI platforms on the unmodified PHP-8.4 branch.
Update the expected output to assert the new warning and false result. Only the PHPT test is changed; this does not alter runtime behavior.
Follow-up to #22083.