Repository navigation
Conversation
The FPM master sends stderr to /dev/null when error_log=syslog. Captured worker stdout/stderr previously always used that descriptor. Route collected worker output to ZLOG_SYSLOG in syslog mode, keeping regular stderr behavior unchanged otherwise. Add a Linux syslog regression test that intercepts syslog calls using LD_PRELOAD without a host syslog daemon. Allow the shim before libasan for the test FPM subprocess so the sanitizer build can execute it. Rebase onto current PHP-8.4 and resolve the NEWS conflict.
localzet
force-pushed
the
fix/gh25077-fpm-worker-syslog
branch
from
November 7, 2026 19:40
5b989c5 to
e640a8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPM sends the master's stderr to /dev/null when error_log=syslog. With catch_workers_output=yes, worker output was always routed to that stderr instead of the existing syslog logger. Choose ZLOG_SYSLOG when the master is configured to use it; otherwise keep the stderr path.
Add a Linux-only regression test that captures both worker stdout and stderr through a test-only LD_PRELOAD syslog interceptor, without needing a host syslog daemon. Skip if no compiler is available or PHP is 32-bit.
The interceptor was compiled and smoke-tested with a glibc syslog caller, including _FORTIFY_SOURCE=2. Native PHP-FPM tests still need to be run.