Repository navigation
Fix GH-24319: Make OPcache hash entry publication and indirection atomic - #25258
Draft
morrisonlevi wants to merge 3 commits into
Draft
morrisonlevi wants to merge 3 commits into
morrisonlevi wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #24319 and #24320 (comment). This branch is an implementation of my suggestion to use a tagged atomic pointer. I verified these problems on both aarch64 and x86_64, but in the wild I've only seen crash reports on aarch64.
The tests were written entirely with AI. I will attempt to clean them up but they are exactly the kind of test that is difficult for humans to write (at least initially). Also, they are quite heavy, and maybe we do not wish to commit them.
The names of my atomic functions are a bit gnarly. When we merge to master, we should change the implementation as atomics have been simplified there.