Repository navigation
Conversation
On master, zend_out_of_memory() calls abort() since phpGH-22637, so run-tests.php appends "Termsig=6" after "Out of memory". The test was written on PHP-8.4, where the process still exits with status 1. The test only runs on non-PIE builds, so CI skips it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
zend_mm_chunk_alloc_mmap_failure.phptfailure reported in GH-25237.The test came with GH-24542, which targeted PHP-8.4. There,
zend_out_of_memory()exits with status 1. On master it callsabort()since GH-22637, sorun-tests.phpappendsTermsig=6afterOut of memory, and the expectation did not allow it. The test only runs on non-PIE builds, so CI skips it and the failure did not show up there.The expectation now accepts
Out of memoryfollowed byTermsig=6, orallocation succeeded. I checked the new pattern against both outputs; the old one rejects the abort output. PHP-8.4 and PHP-8.5 still exit with status 1, so they need no change.Sorry for the breakage, I should have checked the test on master before it was merged up.