Repository navigation
Conversation
ndossche
reviewed
Nov 7, 2026
Comment on lines
+6747
to
+6752
| @@ -6748,6 +6748,8 @@ ZEND_METHOD(ReflectionProperty, isReadable) | |||
| if (!prop->hooks[ZEND_PROPERTY_HOOK_GET]) { | |||
| RETURN_FALSE; | |||
| } | |||
| } else if (prop->flags & ZEND_ACC_VIRTUAL) { | |||
| RETURN_TRUE; | |||
Member
There was a problem hiding this comment.
Suggested change
| RETURN_TRUE; | |
| if (prop->flags & ZEND_ACC_VIRTUAL) { | |
| if (prop->hooks && !prop->hooks[ZEND_PROPERTY_HOOK_GET]) { | |
| RETURN_FALSE; | |
| } |
Member
There was a problem hiding this comment.
It seems bughub messed up the diff, but I hope you see the point
Contributor
Author
There was a problem hiding this comment.
Makes sense, merged the two branches in 81140cb.
ndossche
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal classes like
DOMDocumentdeclare virtual properties without hooks, backed by the object handlers. #21769 stopped asserting on those, but when an object is passedisReadable()still falls into the declared-property branch and readsOBJ_PROP(obj, prop->offset), which is not a real slot for a virtual property. This returns true for virtual properties without hooks, same asisWritable()already does for non-readonly ones.Fixes #25266