Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class implements an interface property it already got from its parent (or from an earlier interface),
do_inherit_property()handsinherit_property_hook()the parent'szend_property_infoas the child, and it writes into it: it sets the prototype of the inherited hook functions and adds the interface's abstract hooks to the shared hooks array. With opcache that memory is in shm, soopcache.protect_memory=1crashes. Without opcache the parent changes for everyone: in the issue's exampleP::$propgets asethook, and afterabstract class C implements J, Iany later class implementing onlyJis asked forI::$prop::set.Inherited hooks are now only checked, not modified, and when an abstract hook has to be added the property info is first copied into the implementing class, which is then abstract anyway.
Fixes #25264