Skip to content

Add "set -e" to important shell scripts - #25279

Open
mvorisek wants to merge 3 commits into
php:masterfrom
mvorisek:set_e_sh
Open

mvorisek wants to merge 3 commits into
php:masterfrom
mvorisek:set_e_sh

Conversation

@mvorisek

@mvorisek mvorisek commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

makedist is important script and it was missing set -e. Failures like non-existing binaries were ignored.

I am however not expect in shell so please review carefuly and possibly advise improvements.

@mvorisek
mvorisek marked this pull request as ready for review November 7, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant