Skip to content

soap: only do a single call to zend_hash_get_current_key() - #25294

Merged
Girgias merged 1 commit into
php:masterfrom
Girgias:2026-11-soap-zend_hash_get_key-common
Nov 8, 2026
Merged

Girgias merged 1 commit into
php:masterfrom
Girgias:2026-11-soap-zend_hash_get_key-common

Conversation

@Girgias

@Girgias Girgias commented Nov 7, 2026

Copy link
Copy Markdown
Member

No need to repeat the work by first calling zend_hash_get_current_key_type() and then zend_hash_get_current_key() depending on the type.

No need to repeat the work by first calling zend_hash_get_current_key_type() and then zend_hash_get_current_key() depending on the type.
@Girgias
Girgias marked this pull request as ready for review November 7, 2026 18:06
@Girgias
Girgias requested a review from devnexen as a code owner November 7, 2026 18:06
@Girgias
Girgias merged commit 5859090 into php:master Nov 8, 2026
18 checks passed
@Girgias
Girgias deleted the 2026-11-soap-zend_hash_get_key-common branch November 8, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants