[jorgsowa]

The AST export of static method calls and class constant fetches prints dynamic member names without braces, even when the bare name doesn't lex as an identifier. The exported code then fails to parse:

assert(false && C::{'__halt_compiler'}());
// AssertionError: assert(false && C::__halt_compiler())
// re-parsing it: syntax error, unexpected token "__halt_compiler"

Three cases are affected:

• __halt_compiler: T_HALT_COMPILER is the only keyword the grammar does not accept as an identifier, so C::{'__halt_compiler'} cannot be written as C::__halt_compiler.
• Names that aren't valid labels: static call names went through the variable-name export path, so C::{'a b'}() became C::{a b}() and C::{''}() became C::{}().
• public/protected/private calls: C::public( set ) was exported as C::public(set), which the lexer reads as the single T_PUBLIC_SET token.

These names are now exported in braces: C::{'_halt_compiler'}(), C::{'a b'}(), C::{'public'}(set). A static call named public, protected or private is always braced, because only its arguments decide whether it would lex as T*_SET, and the braced form is always valid.

Follow-up to #25221.

[iliaal]

zend_ast_export_var() has the same unquoted-brace problem for the other member kinds: $o->{'a b'}(), $o?->{'a b'}(), $o->{'a b'}, C::${'a b'} and ${'a b'} all still export as {a b}. Exporting the ZVAL with zend_ast_export_ex() inside the braces there would fix all of them, and the static call path would only need the __halt_compiler/public(set) checks.

[jorgsowa]

I'm not gonna fix it on 8.4. Whole zend_ast is too buggy on 8.4 to reliable make separate fixes. This problem is partially already fixed on 8.6, so I will create separate branch to address it only for 8.6. Thank you for review