Skip to content

Reapply "Use __attribute__((assume())) in ZEND_ASSUME when available" #25332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamil-tekiela wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −0
Open

Reapply "Use __attribute__((assume())) in ZEND_ASSUME when available" #25332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366aa18
Reapply "Use __attribute__((assume())) in ZEND_ASSUME when available"
kamil-tekiela Nov 9, 2026
74ec5f2
Apply suggestion from @iluuu1994
kamil-tekiela Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Zend/zend_portability.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ using std::memory_order_acquire;

#if defined(ZEND_WIN32) && !defined(__clang__)
# define ZEND_ASSUME(c) __assume(c)
#elif defined(__GNUC__) && !defined(__clang__) && __GNUC__ >= 14
/* GCC emits a warning when __attribute__ appears directly after a label, so we need a do-while loop. */
# define ZEND_ASSUME(c) do { __attribute__((assume(c))); } while (0)
#elif defined(__clang__) && __has_builtin(__builtin_assume)
# pragma clang diagnostic ignored "-Wassume"
# define ZEND_ASSUME(c) __builtin_assume(c)
Expand Down
Loading