Skip to content

Add test for filter_var_array() leak when a nested element throws #25365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyupcanakman wants to merge 1 commit into
base: PHP-8.5
Choose a base branch
from
Open

Add test for filter_var_array() leak when a nested element throws #25365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions ext/filter/tests/filter_var_array_exception_leak.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
--TEST--
filter_var_array() does not leak the filtered value when filtering it throws
--EXTENSIONS--
filter
--FILE--
<?php
try {
filter_var_array(['a' => ['1', 'x']], ['a' => ['filter' => FILTER_VALIDATE_INT, 'flags' => FILTER_REQUIRE_ARRAY | FILTER_THROW_ON_FAILURE]]);
} catch (Filter\FilterFailedException $e) {
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}

try {
filter_var_array(['a' => ['1', 'x']], ['a' => ['filter' => FILTER_CALLBACK, 'options' => function ($value) {
if ($value === 'x') {
throw new Exception('callback failed');
}
return $value;
}]]);
} catch (Exception $e) {
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
?>
--EXPECT--
Filter\FilterFailedException: filter validation failed: filter int not satisfied by 'x'
Exception: callback failed
Loading