Skip to content

JIT: Minor optimizations to static property access #25381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndossche merged 3 commits into from
Nov 11, 2026
Merged

JIT: Minor optimizations to static property access #25381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f93d679
JIT: Avoid run time cache reload in static property access
ndossche Nov 10, 2026
b13050a
JIT: Optimize final class scope check for static property access
ndossche Nov 10, 2026
a4894b6
remove redundant trait check
ndossche Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions ext/opcache/jit/zend_jit_ir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16437,20 +16437,32 @@ static int zend_jit_fetch_static_prop(zend_jit_ctx *jit, const zend_op *opline,
default: ZEND_UNREACHABLE();
}

if (is_static) {
ir_ref run_time_cache_ptr = IR_UNUSED;
if (is_static
&& op_array->function_name
&& op_array->scope
&& (op_array->scope->ce_flags & ZEND_ACC_FINAL)
&& !(op_array->fn_flags & (ZEND_ACC_CLOSURE|ZEND_ACC_TRAIT_CLONE))) {
/* A method in a final CE has a called scope equal to the scope.
* So the cache slot is always monomorphic.
* Closures are excluded because they can be bound to another scope, likewise traits are shared. */
} else if (is_static) {
/* The cache slot is polymorphic on the called scope. */
// JIT: if (CACHED_PTR(cache_slot) == called_scope)
run_time_cache_ptr = ir_LOAD_A(jit_EX(run_time_cache));
ir_ref if_scope = ir_IF(ir_EQ(
ir_LOAD_A(ir_ADD_OFFSET(ir_LOAD_A(jit_EX(run_time_cache)), cache_slot)),
ir_LOAD_A(ir_ADD_OFFSET(run_time_cache_ptr, cache_slot)),
jit_called_scope(jit, op_array)));
ir_IF_FALSE_cold(if_scope);
ir_END_list(slow_inputs);
ir_IF_TRUE(if_scope);
}

// JIT: result = CACHED_PTR(cache_slot + sizeof(void *));
ref = ir_LOAD_A(
ir_ADD_OFFSET(ir_LOAD_A(jit_EX(run_time_cache)), cache_slot + sizeof(void*)));
if (run_time_cache_ptr == IR_UNUSED) {
run_time_cache_ptr = ir_LOAD_A(jit_EX(run_time_cache));
}
ref = ir_LOAD_A(ir_ADD_OFFSET(run_time_cache_ptr, cache_slot + sizeof(void*)));

// JIT: if (result)
if_cached = ir_IF(ref);
Expand All @@ -16467,7 +16479,7 @@ static int zend_jit_fetch_static_prop(zend_jit_ctx *jit, const zend_op *opline,
if (!known_prop_info) {
// JIT: if (ZEND_TYPE_IS_SET(property_info->type))
prop_info_ref = ir_LOAD_L(
ir_ADD_OFFSET(ir_LOAD_A(jit_EX(run_time_cache)), cache_slot + sizeof(void*) * 2));
ir_ADD_OFFSET(run_time_cache_ptr, cache_slot + sizeof(void*) * 2));
if_typed = ir_IF(ir_AND_U32(
ir_LOAD_U32(ir_ADD_OFFSET(prop_info_ref, offsetof(zend_property_info, type.type_mask))),
ir_CONST_U32(_ZEND_TYPE_MASK)));
Expand Down Expand Up @@ -16496,7 +16508,7 @@ static int zend_jit_fetch_static_prop(zend_jit_ctx *jit, const zend_op *opline,
if (!known_prop_info) {
// JIT: if (ZEND_TYPE_IS_SET(property_info->type))
prop_info_ref = ir_LOAD_L(
ir_ADD_OFFSET(ir_LOAD_A(jit_EX(run_time_cache)), cache_slot + sizeof(void*) * 2));
ir_ADD_OFFSET(run_time_cache_ptr, cache_slot + sizeof(void*) * 2));
if_typed = ir_IF(ir_AND_U32(
ir_LOAD_U32(ir_ADD_OFFSET(prop_info_ref, offsetof(zend_property_info, type.type_mask))),
ir_CONST_U32(_ZEND_TYPE_MASK)));
Expand Down
40 changes: 40 additions & 0 deletions ext/opcache/tests/jit/fetch_static_prop_static_final_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
--TEST--
JIT: FETCH_STATIC_PROP static:: in a final class
--EXTENSIONS--
opcache
--INI--
opcache.enable=1
opcache.enable_cli=1
opcache.jit_hot_func=1
--FILE--
<?php
final class FinalClass {
public static $prop = 'FinalClass';

function get() {
return static::$prop;
}
}

class NonFinal {
public static $prop = 'NonFinal';

function get() {
return static::$prop;
}
}

class NonFinalChild extends NonFinal {
public static $prop = 'NonFinalChild';
}

foreach ([new FinalClass, new FinalClass, new NonFinal, new NonFinalChild, new NonFinal] as $obj) {
var_dump($obj->get());
}
?>
--EXPECT--
string(10) "FinalClass"
string(10) "FinalClass"
string(8) "NonFinal"
string(13) "NonFinalChild"
string(8) "NonFinal"
Loading