Skip to content

Fix GH-25388: Stale ext/date tz cache after logging during startup #25407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: PHP-8.4
Choose a base branch
from
Open

Fix GH-25388: Stale ext/date tz cache after logging during startup #25407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6913b72
Fix GH-25388: Stale ext/date tz cache after logging during startup
lazerg Nov 12, 2026
3517fdc
Use the issue title in the GH-25388 test
lazerg Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/date/php_date.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ PHP_RINIT_FUNCTION(date)
efree(DATEG(timezone));
}
DATEG(timezone) = NULL;
DATEG(tzcache) = NULL;
DATEG(last_errors) = NULL;

return SUCCESS;
Expand Down Expand Up @@ -499,6 +498,11 @@ static timelib_tzinfo *php_date_parse_tzfile(const char *formal_tzname, const ti
timelib_tzinfo *tzi;
int dummy_error_code;

/* Startup memory is released before the first request, so don't cache it */
if (!EG(active)) {
return timelib_parse_tzfile(formal_tzname, tzdb, &dummy_error_code);
}

if(!DATEG(tzcache)) {
ALLOC_HASHTABLE(DATEG(tzcache));
zend_hash_init(DATEG(tzcache), 4, NULL, _php_date_tzinfo_dtor, 0);
Expand Down
23 changes: 23 additions & 0 deletions ext/date/tests/gh25388.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
--TEST--
GH-25388 (Invalid access or leak of startup data for ext/date after early usage (php_log_err in minit+rinit))
--CREDITS--
bwoebi
--INI--
allow_url_include=1
log_errors=1
error_log={PWD}/gh25388.log
output_handler=inexistent
date.timezone=Europe/Berlin
--FILE--
<?php
echo date('e'), "\n";
?>
--CLEAN--
<?php
@unlink(__DIR__ . '/gh25388.log');
?>
--EXPECT--
Deprecated: Directive 'allow_url_include' is deprecated in Unknown on line 0

Warning: PHP Request Startup: function "inexistent" not found or invalid function name in Unknown on line 0
Europe/Berlin
Loading