Repository navigation
Conversation
set(int $v) => $v was exported as set => $v, and hook attributes were dropped.
iliaal
approved these changes
Nov 12, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks. Nit: zend_ast_export_attributes(str, hook->child[4], indent, true), the other call sites pass true/false.
Contributor
Author
|
Thanks. The formatting is completely off. I think we should improve it when all ast gaps are patched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set(int $v) => $vwas exported asset => $v, and hook attributes were dropped.Follow-up #25069 (review)