Repository navigation
Fix GH-25402: ext/openssl build failure against OpenSSL 1.0.2 - #25424
Open
ChrisOrlando wants to merge 1 commit into
Open
ChrisOrlando wants to merge 1 commit into
ChrisOrlando wants to merge 1 commit into
Conversation
19255f4 ("Backport compatibility changes for OpenSSL 4.0") switched the IP SAN matching in php_openssl_matches_san_list() to ASN1_STRING_get0_data(), which was only added in OpenSSL 1.1.0. PHP 8.2 and 8.3 still support OpenSSL 1.0.2, and openssl.c already carries a fallback for it, but that one is static to openssl.c, so xp_ssl.c no longer compiled against 1.0.2. Add the equivalent fallback to xp_ssl.c under the same PHP_OPENSSL_API_VERSION < 0x10100 guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
19255f4 ("Backport compatibility changes for OpenSSL 4.0") switched the IP SAN matching in php_openssl_matches_san_list() to ASN1_STRING_get0_data(), which was only added in OpenSSL 1.1.0. PHP 8.2 and 8.3 still support OpenSSL 1.0.2, and openssl.c already carries a fallback for it, but that one is static to openssl.c, so xp_ssl.c no longer compiled against 1.0.2.
Add the equivalent fallback to xp_ssl.c under the same PHP_OPENSSL_API_VERSION < 0x10100 guard.