Repository navigation
Conversation
getSymbol()/setSymbol() cast the zend_long to UNumberFormatSymbol before range-checking it, so values like 2**32 wrapped into the valid range.
devnexen
reviewed
Nov 12, 2026
| RETURN_FALSE; | ||
| } | ||
|
|
||
| UNumberFormatSymbol symbol = static_cast<UNumberFormatSymbol>(lsymbol); |
Member
There was a problem hiding this comment.
I think you can apply the same logic in numfmt_get_attribute and numfmt_set_attribute too.
Contributor
Author
There was a problem hiding this comment.
Applied the fix. There are few missing value checks in this file as well, but it's not PHP 8.6 regression so I would just make in separate PR.
getAttribute()/setAttribute() switched on the value after casting it to UNumberFormatAttribute, so values like 2**32 + MAX_FRACTION_DIGITS wrapped into a valid attribute.
devnexen
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSymbol()/setSymbol()cast thezend_longtoUNumberFormatSymbolbefore range-checking it, so values like 2**32 wrapped into the valid range.Regression on PHP8.6 branch.