Add Cache-Control header to revcheck.php for improved caching - #70
Open
sy-records wants to merge 1 commit into
Open
Add Cache-Control header to revcheck.php for improved caching#70sy-records wants to merge 1 commit into
sy-records wants to merge 1 commit into
Conversation
derickr
requested changes
Sep 1, 2026
| } | ||
|
|
||
| site_header(); | ||
| header('Cache-Control: public, max-age=3600'); |
Member
There was a problem hiding this comment.
There is a way how to do this through site_header in https://github.com/php/web-php/blob/master/include/layout.inc#L445 and https://github.com/php/web-php/blob/master/include/header.inc#L56 — and I think a similar approach should be taken here. It's going to be more consistent among sites. We could also set a different value for each of the .php files in this repository.
I also see that in www/revcheck.php there are some site_header() calls that really ought to cause a 404 or something else, as they're error situations. (Perhaps for a different PR though)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caching can result in retrieving outdated information; I'm not sure if we should set different time values based on
$tool.https://doc.php.net/revcheck.php?p=files&lang=zh