Skip to content

Split conferences and CFPs - #2058

Merged
derickr merged 2 commits into
php:masterfrom
mattstauffer:mes/conferences-split
Nov 12, 2026
Merged

Split conferences and CFPs#2058
derickr merged 2 commits into
php:masterfrom
mattstauffer:mes/conferences-split

Conversation

@mattstauffer

@mattstauffer mattstauffer commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

On the /conferences/ page, split out views for conferences (for attendees) and CFPs (for speakers).

Also cleans up a few lines of CSS with inconsistent styling from the rest of main.css

image image

@mattstauffer
Split conferences and CFPs
efc15aa 
On the /conferences/ page, split out views for conferences (for attendees) and CFPs (for speakers)
@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

📊 Regression report for commit efc15aa is at https://web-php-regression-report-pr-2058.preview.thephp.foundation

@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview for commit efc15aa is available at https://web-php-pr-2058.preview.thephp.foundation

@derickr

derickr commented Nov 11, 2026

Copy link
Copy Markdown
Member

It doesn't seem to work in the preview: https://web-php-pr-2058.preview.thephp.foundation/conferences

derickr
derickr requested changes Nov 11, 2026
View reviewed changes

@derickr derickr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments about the code, and no comments about the layout or approach.

Comment thread src/News/ConferenceSchedule.php Resolved
Comment thread public/conferences/index.php Resolved
Comment thread src/News/ConferenceSchedule.php Resolved
@mattstauffer

mattstauffer commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

All concerns addressed @derickr -- thanks!

@sy-records

sy-records commented Nov 12, 2026

Copy link
Copy Markdown
Member

It doesn't seem to work in the preview: https://web-php-pr-2058.preview.thephp.foundation/conferences

Yes, the conference resources seem to be synchronized from other places. There is no data here.

@derickr

derickr commented Nov 12, 2026

Copy link
Copy Markdown
Member

It doesn't seem to work in the preview: https://web-php-pr-2058.preview.thephp.foundation/conferences

Yes, the conference resources seem to be synchronized from other places. There is no data here.

That wasn't the problem. The problem was that the preview server runs 8.2, and the private(set) syntax doesn't exist there yet.

@derickr
derickr merged commit f895103 into php:master Nov 12, 2026
4 checks passed
@mattstauffer
mattstauffer deleted the mes/conferences-split branch November 12, 2026 17:23
@mattstauffer

mattstauffer commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for your review!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derickr derickr derickr requested changes
@saundefined saundefined Awaiting requested review from saundefined saundefined is a code owner
@sy-records sy-records Awaiting requested review from sy-records sy-records is a code owner
@sgolemon sgolemon Awaiting requested review from sgolemon sgolemon is a code owner

Assignees

No one assigned

Labels

Status: Preview Allowed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattstauffer @derickr @sy-records