Repository navigation
Address validation notes - #3
Merged
Merged
Conversation
- Limit the ACP icon class to 64 characters on the server as well as in the form, so it always fits the config value column. - Name template variables by phpBB's conventions: U_COPYLINKS_BOARD for the board URL and S_COPYLINKS_ICON_ENABLE for the on/off switch. - Use a boolean for the icon switch instead of 1/0, and a named constant for the screen reader announcement delay. - Check out the extension with actions/checkout@v4, like phpBB itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the notes from a validation pass in the style of phpBB.com's Customisations Team. The pass found no security issues and nothing that would block approval.
Changes
maxlengthcomes from the same constant.U_COPYLINKS_BOARDand the on/off switch isS_COPYLINKS_ICON_ENABLE.? 1 : 0, and the 50 ms delay before the screen reader message is now a named constant,ANNOUNCE_DELAY.tests.ymlusesactions/checkout@v4, the same version as the phpBB checkout.Not changed:
composer.jsonkeeps version1.0.0-dev. phpBB.com only accepts stable versions, so it needs a stable number before it's submitted there.Testing
Claude tested this on seed-forum boards running phpBB 3.3 and phpBB 4.0:
fa-clone, and the checkbox showed the saved state.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code