Repository navigation
feature_checks: add a tlink check - #48
Merged
Merged
Conversation
Posts a topic with a link through posting.php and checks it is stored and locked, then calls submit_post() without topic_first_post_id and post_id and checks no PHP warning comes out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
feature_checks.pycheck forphpbbstudio/tlink:submit_post()withouttopic_first_post_idandpost_id, as importers and fixture scripts do, and fails on any PHP warning or notice. This is the regression test for the tlink fix in phpbbmodders/tlink (separate PR).Claude ran it with
--seed-boardon a seed-forum phpBB 3.3.19 SQLite board: 9/9 with the fix (twice on the same board); with the old tlink line, thesubmit_post()check fails as expected.tests/test-phpbb-test-board.shpasses locally.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code