Repository navigation
Remove the attachment list from the print-all page - #10
Merged
Merged
Conversation
The loop never matched phpBB's attachment rows, so it printed nothing. phpBB's own print view shows no attachments, so the print-all page now leaves them out on purpose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bonelifer
added a commit
that referenced
this pull request
Oct 28, 2026
* Show each post's attachments on the print-all page The attachment list read loops.attachment, which never holds a post's attachments, so it printed an empty heading. It was then removed (#10); this puts it back, reading postrow.attachment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bump version to 1.0.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the attachment list from the Print all page.
The loop read
loops.attachment, which never holds a post's attachments, so a post with attachments printed an empty Attachments: heading. This removed the list rather than fixing the loop; #11 puts it back with the loop fixed.Claude added a feature check for this in phpbbmodders/phpbb-release-tools (
feature_checks.py). Onmasterit fails (the empty heading is there); with this change all 4 checks pass. The check also confirms that with one post per page, the Print all page still shows every post.Investigated and written by Claude on behalf of William Jacoby (bonelifer).