Repository navigation
feat: add node batches 2 and 3 with their templates - #32
Merged
Merged
Conversation
- Add the 20 remaining catalogue nodes: Deduplicate, Auto-trim, Pad / Extend, Pixel-art upscale, Split / Tile, Adjust, Filters, Sharpen / Blur, Background, Text watermark, Image watermark, Border / Rounded corners, Set copyright / author, Best format, Responsive set, Favicon / App icons, Placeholder, Palette, Contact sheet and Images to PDF - Add the Watermark and compress, Instagram carousel and Responsive image set templates - Let combining nodes pass their inputs on by reference, so Deduplicate never holds the batch and kept items keep their step cache and source (ADR 0011) - Carry data and document items to Output and Rename; ICO files are documents (ADR 0012) - Show settings forms, summaries and icons for the new nodes in the Studio, and the text of data items in the inspector - Estimate work through Deduplicate, and refuse a save the browser has no room for instead of failing silently - Shard the node pair matrix so browsers run it in parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phases 2 and 3 of
implementation.md: the 20 remaining catalogue nodes, their templates and their Studio forms.No new dependencies: BlurHash, the PDF writer and the ICO writer are small in-repo modules.
Testing
pnpm validate: 1,873 tests and the production build pass. Coverage is 63.5% of statements.pnpm test:scale(500 images of 12 megapixels) passes.