fix: compare PLEX_UPDATE_CHANNEL numerically - #181
Open
lbellows wants to merge 1 commit into
Open
Conversation
The previous test used '>' inside '[ ]', which redirects to a file named 0 instead of comparing integers. Quote PLEX_CLAIM_FILE when reading the claim token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[ "${PLEX_UPDATE_CHANNEL}" > 0 ]is a redirect, not a comparison. When the variable is set it created a file named0in the working directory and treated any non-empty value as true.Use a numeric
-gttest (non-numeric values fail closed) and quotePLEX_CLAIM_FILEwhen reading the claim token.Test plan
bash -n root/plex-common.sh root/etc/cont-init.d/40-plex-first-run[ > 0 ]creating a file named0-gtaccepts16, rejects0, fails closed on non-numeric, and does not create0PLEX_CLAIM_FILEis quoted