Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-latest
# work around lcov bug #316; remove once lcov is fixed (see https://github.com/linux-test-project/lcov/issues/316)
env:
LCOBUG: "--ignore-errors mismatch"
LCOBUG: "--ignore-errors mismatch,inconsistent,inconsistent"

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#include <memory>
#include <set>
#include <cstdint>

#include "algorithm/robotics/astar_variant/heuristic.hpp"
#include "algorithm/robotics/astar_variant/map_storage.hpp"
Expand Down
2 changes: 2 additions & 0 deletions src/robotics/astar_variant/src/astar_variant_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

#include "algorithm/robotics/astar_variant/astar_variant_base.hpp"

#include <algorithm>

namespace pllee4::graph {
void AstarVariantBase::SetMapStorageSize(const size_t x_size,
const size_t y_size) {
Expand Down Expand Up @@ -155,7 +157,7 @@
std::tie(x, y) = std::pair(temp_x, temp_y);
}
path.emplace_back(Coordinate{x, y});
std::reverse(path.begin(), path.end());

Check warning on line 160 in src/robotics/astar_variant/src/astar_variant_base.cpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::reverse" that takes a range.

See more on https://sonarcloud.io/project/issues?id=pllee4_algorithm&issues=AaGhFys0OnKJvo_QU1gg&open=AaGhFys0OnKJvo_QU1gg&pullRequest=20
return path;
} else {
return std::nullopt;
Expand All @@ -172,7 +174,7 @@
void AstarVariantBase::ResetFunc(bool reset_cost_only) {
traverse_path_.clear();
for (auto &row : visited_map_) {
std::fill(row.begin(), row.end(), false);

Check warning on line 177 in src/robotics/astar_variant/src/astar_variant_base.cpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::fill" that takes a range.

See more on https://sonarcloud.io/project/issues?id=pllee4_algorithm&issues=AaGhFys0OnKJvo_QU1gh&open=AaGhFys0OnKJvo_QU1gh&pullRequest=20
}
if (reset_cost_only) {
map_storage_->ResetCost();
Expand Down
Loading