build(deps): drop pytest-cases for pytest 9.1 - #279
Open
toby-coleman wants to merge 1 commit into
Open
Conversation
pytest-cases 3.10.1 builds the private _pytest.python.IdMaker positionally, so it fails to import under pytest 9.1, and its SuperClosure prunes the fixture that pytest-asyncio 1.4 injects for loop factories. Both upstream fixes are unreleased, so the test extras were pinned below those versions. The suite used pytest-cases only to reference a fixture from a parametrisation. Fixture unions become plain parametrised fixtures plus pytest-lazy-fixtures lf(), which resolves references through public pytest APIs, so the pytest and pytest-asyncio bounds reopen. The uvloop loop factory hook also takes effect for the first time: pytest-asyncio 1.3 has no such hookspec, so the suite ran on the default event loop. tests/unit/test_conftest.py now asserts the running loop instead of the hook return value. Refs smarie/python-pytest-cases#385
|
Benchmark comparison for |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest-caseshas not been updated for 6 months, and does not work with newer versions of pytest smarie/python-pytest-cases#385 and pytest-asyncio. This PR replaces it, usingpytest-lazy-fixtureswhere required.Changes
pytest-casespytestandpytest-asyncio