Refactor getAncestorDirs to iterate instead of recurse - #526
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors getAncestorDirs in index.js to use an iterative loop rather than recursion, aligning with the goal of avoiding recursive call overhead/stack growth while generating ancestor directory paths.
Changes:
- Replaced the recursive implementation of
getAncestorDirswith awhile-loop implementation. - Preserved the function’s documented output ordering for absolute paths (e.g.,
['/imports/components', '/imports', '/']).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+357
to
360
| while (current !== root) { | ||
| current = path.dirname(current) | ||
| ancestors.push(current) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.