BREAKING: exit on all types of configuration errors in watch mode - #527
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates watch mode to exit on initial configuration errors while continuing after file-processing errors.
Changes:
- Makes error termination explicit via
dontExit. - Adds watch-mode coverage for configuration failures.
- Preserves watch mode after processing errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
index.js |
Refines error handling and watch-mode exit behavior. |
test/error.js |
Tests configuration errors in normal and watch modes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to exit watch mode if there's a processing error, but a configuration error on initial run should exit. Some of these cases did exit, but with an additional, unhelpful error message, since we proceeded beyond the error condition.