Use spawn to fix zombie processes from tests - #529
Merged
Conversation
RyanZim
force-pushed
the
ryan/fix-watch-tests
branch
from
August 20, 2026 19:57
0717630 to
791cba6
Compare
RyanZim
force-pushed
the
ryan/fix-watch-tests
branch
from
August 20, 2026 20:22
edf5094 to
be6aac0
Compare
RyanZim
force-pushed
the
ryan/fix-watch-tests
branch
from
August 20, 2026 20:25
be6aac0 to
68d4df4
Compare
RyanZim
marked this pull request as ready for review
August 20, 2026 20:28
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces shell-based watch test processes with direct spawning to prevent orphaned/zombie processes.
Changes:
- Uses
spawnwith explicit argument arrays. - Re-enables the CSS syntax error watch test in CI.
- Preserves literal glob argument handling.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered that running the tests left zombie processes running; this fixes this.