Repository navigation
Preserve the installed CLI when website installer replacement fails - #593
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website installer preserves the installed executable when a transfer into the installation directory fails. The replacement is staged inside that directory, checked for nonempty executable contents, and committed with a same-filesystem rename. Cleanup removes only the attempt's private staging directory.
Validation on Linux: 23 installer tests pass with 192 assertions, covering failure preservation, prepared modes, symlinks, and eight concurrent upgrade schedules. The transfer-failure, empty-source, and empty-stage regressions fail against the original installer and pass against this change. The canonical service review returns an operational error without a code verdict; focused installer and shell syntax checks pass.