Repository navigation
Audit of the #4, #5, #6 fixes: nested groupBy keys, docs, tests - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8.
groupBygrouped across parents: the same child value under two parents shared one tree key, so the second parent lost the element and the first parent's element was replaced. Nested keys are now prefixed with the parent key. Adds unit tests for partial-null nested rows, two-level nesting, column-index and no-column maps, and aGroupByTestLEFT JOIN case that runs against every database.cacheModelattribute in the insert, update, delete and cacheModel reference pages. Adds unit tests for a cache model declared in another mapping file, a statement both listed influshOnExecuteand carrying the attribute, and aCacheTestcase that runs against every database.@throwstags ofTPropertyAccess::get()/set()and documents path resolution. Adds tests with a customArrayAccessclass that provesoffsetExists()/offsetGet()are used, plus null values, nested misses andset()on anArrayAccessroot.