AdPlayx: New Adapter by anuraj700 · Pull Request #4582 · prebid/prebid-server-java

anuraj700 · 2026-07-31T15:39:54Z

Type of Change

New bidder adapter
Bug fix
Feature / Enhancement
Documentation update

Description

This PR adds the AdPlayx bidder adapter implementation (adplayx) to Prebid Server Java, supporting ORTB 2.6 requests for Banner and Video inventory.

Key Changes Made:

Added AdplayxBidder.java to handle request construction with query parameters (apptoken, placementid) and bid response parsing.
Added ExtImpAdplayx.java model for extracting adapter parameters.
Added bidder configuration (adplayx.yaml, AdplayxConfiguration.java).
Added parameter validation schema (static/bidder-params/adplayx.json).
Added unit test suite AdplayxBidderTest.java targeting >80% code coverage using JUnit 5 and AssertJ.

Checklist

Code passes checkstyle:check without line length or final modifier violations.
Unit tests pass locally (mvn test -Dtest=AdplayxBidderTest).
Parameters match JSON schema defined in static/bidder-params/adplayx.json.
Added configuration in bidder-config/adplayx.yaml.

Testing Instructions

Run unit tests locally:

mvn test -Dtest=AdplayxBidderTest

### 🔧 Type of changes
- [ ] new bid adapter
- [ ] bid adapter update
- [ ] new feature
- [ ] new analytics adapter
- [ ] new module
- [ ] module update
- [ ] bugfix
- [ ] documentation
- [ ] configuration
- [ ] dependency update
- [ ] tech debt (test coverage, refactorings, etc.)

### ✨ What's the context?
What's the context for the changes?

### 🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?

### 🔎 New Bid Adapter Checklist
- [ ] verify email contact works
- [ ] NO fully dynamic hostnames
- [ ] geographic host parameters are NOT required
- [ ] direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job*
- [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - *define the new adapter as the alias of the generic adapter*
- [ ] cover an adapter configuration with an integration test

### 🧪 Test plan
How do you know the changes are safe to ship to production?

### 🏎 Quality check
- [ ] Are your changes following [our code style guidelines](https://github.com/prebid/prebid-server-java/blob/master/docs/developers/code-style.md)?
- [ ] Are there any breaking changes in your code?
- [ ] Does your test coverage exceed 90%?
- [ ] Are there any erroneous console logs, debuggers or leftover code in your changes?

## Type of Change - [x] New bidder adapter - [ ] Bug fix - [ ] Feature / Enhancement - [ ] Documentation update ## Description This PR adds the **AdPlayx** bidder adapter implementation (`adplayx`) to Prebid Server Java, supporting ORTB 2.6 requests for Banner and Video inventory. ### Key Changes Made: - Added `AdplayxBidder.java` to handle request construction with query parameters (`apptoken`, `placementid`) and bid response parsing. - Added `ExtImpAdplayx.java` model for extracting adapter parameters. - Added bidder configuration (`adplayx.yaml`, `AdplayxConfiguration.java`). - Added parameter validation schema (`static/bidder-params/adplayx.json`). - Added unit test suite `AdplayxBidderTest.java` targeting >80% code coverage using JUnit 5 and AssertJ. ## Checklist - [x] Code passes `checkstyle:check` without line length or final modifier violations. - [x] Unit tests pass locally (`mvn test -Dtest=AdplayxBidderTest`). - [x] Parameters match JSON schema defined in `static/bidder-params/adplayx.json`. - [x] Added configuration in `bidder-config/adplayx.yaml`. ## Testing Instructions Run unit tests locally: ```bash mvn test -Dtest=AdplayxBidderTest

CTMBNara

Update branch with latest master. Use Uri.java instead of macros (it will encode all the params, so make sure to not double encode them).

- Remove {{apptoken}} macro template from bidder config - Append apptoken and placementid dynamically using URIBuilder - Update unit tests to verify parameter building and single-encoding behavior

…/prebid-server-java into adding-adapter-adplayx

anuraj700 · 2026-08-15T05:51:33Z

Update branch with latest master. Use Uri.java instead of macros (it will encode all the params, so make sure to not double encode them).

Resolved the review comments.

Replace org.apache.http.client.utils.URIBuilder with org.prebid.server.util.Uri in AdplayxBidder to eliminate the deprecated Apache HTTP client dependency. - Updated buildEndpointUrl() to use Uri.of() and addQueryParam() - Updated AdplayxBidderTest assertions to align with Vert.x UriTemplate encoding style

CTMBNara

Add integration test. Use AxisTest as an example

- Update URI parameter handling using Uri.of in constructor - Adopt standard stream-based bid parsing and BidderUtil.defaultRequest - Add AdplayxTest integration test suite

anuraj700 · 2026-09-03T04:15:25Z

Add integration test. Use AxisTest as an example

Added

As per review comments - resolving the excess check

osulzhenko · 2026-09-22T16:32:19Z

@anuraj700 pls fix checkstyle:

[ERROR] /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/adplayx/AdplayxBidder.java:24:8: Unused import - org.prebid.server.util.HttpUtil. [UnusedImports]
[ERROR] /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/it/AdplayxTest.java:11:15: Unused import - com.github.tomakehurst.wiremock.client.WireMock.anyUrl. [UnusedImports]

anuraj700 · 2026-09-26T09:58:00Z

@anuraj700 pls fix checkstyle:

[ERROR] /home/runner/work/prebid-server-java/prebid-server-java/src/main/java/org/prebid/server/bidder/adplayx/AdplayxBidder.java:24:8: Unused import - org.prebid.server.util.HttpUtil. [UnusedImports]
[ERROR] /home/runner/work/prebid-server-java/prebid-server-java/src/test/java/org/prebid/server/it/AdplayxTest.java:11:15: Unused import - com.github.tomakehurst.wiremock.client.WireMock.anyUrl. [UnusedImports]

@osulzhenko Fixed, Please review

osulzhenko · 2026-09-29T12:13:25Z

@anuraj700 Some of your integration and unit tests are failing

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   AdplayxTest.openrtb2AuctionShouldRespondWithBidsFromAdplayx:33->IntegrationTest.assertJsonEquals:251 seatbid[]: Expected 1 values but got 0 ; 
Unexpected: ext
 ; 
Unexpected: nbr

[ERROR] Errors: 
[ERROR]   AdplayxBidderTest.makeBidsShouldReturnEmptyListWhenResponseIsNull:116 » IllegalArgument argument "content" is null
[INFO] 
[ERROR] Tests run: 8834, Failures: 1, Errors: 1, Skipped: 2

anuraj700 · 2026-10-03T08:13:17Z

@osulzhenko I have fixed unit as well as integration test.

CTMBNara · 2026-10-05T12:59:00Z

+        if (httpCall.getResponse().getBody() == null) {
+            return Result.of(Collections.emptyList(), errors);
+        }


@CTMBNara Removed . Please review

anuraj700 · 2026-10-14T13:26:38Z

@osulzhenko This failure seems unrelated. Can you please check

anuraj700 · 2026-10-18T02:23:05Z

@CTMBNara @osulzhenko

The job failed because one functional test suite failed, and the workflow is configured to stop on any failed tests.

What the log shows:

The failing suite is:
- org.prebid.server.functional.tests.postgres.PostgresDBSpec
Test name:
- “PBS with postgresql should proceed with stored requests and responses correctly”
Actual exception:
- org.testcontainers.containers.ContainerLaunchException: Container startup failed for image prebid/prebid-server:latest

So the root cause is not a normal assertion failure in the app logic; it’s a Testcontainers/PostgreSQL environment startup problem. The job then ends with:

“Failed test were found and 'fail-on-error' option is set to true”

This is from the functional test workflow at:

.github/workflows/pr-functional-tests.yml

In short: the job failed because the Postgres test container could not start, causing that single test to fail and the workflow to mark the job as failed.

anuraj700 · 2026-10-22T15:24:07Z

@CTMBNara @osulzhenko

this is still in pending state and not merged
Could you please help in getting this merged

I checked the log for job 115296308445.

Why it failed:

The workflow did not fail because of a broad code regression. It failed because one test suite failed:
- TEST-org.prebid.server.functional.tests.postgres.PostgresDBSpec.xml
The log shows:
- 1 test completed
- 0 passed
- 1 failed
- Failure: "PBS with postgresql should proceed with stored requests and responses correctly"
- Root cause:
  - org.testcontainers.containers.ContainerLaunchException: Container startup failed for image prebid/prebid-server:latest

So the actual error is a Testcontainers/Docker startup failure, not a test assertion failure. The job then exits with an error because the functional test workflow has a step configured with fail-on-error: true, which is why GitHub marks the job as failed even though the rest of the suites were green.

Relevant workflow file:

.github/workflows/pr-functional-tests.yml

The key failing excerpt from the logs is:

❌ TEST-org.prebid.server.functional.tests.postgres.PostgresDBSpec.xml
1 tests were completed in 188s with 0 passed, 1 failed and 0 skipped.
org.testcontainers.containers.ContainerLaunchException: Container startup failed for image prebid/prebid-server:latest

In short: the job failed because the Postgres functional test could not start its Docker container, and the workflow treats that as a failing test.

CTMBNara requested changes Aug 7, 2026

View reviewed changes

anuraj700 added 3 commits August 15, 2026 10:56

Merge branch 'prebid:master' into adding-adapter-adplayx

4b6de5d

adplayx: construct request URI using URIBuilder instead of macros

87a6ff3

- Remove {{apptoken}} macro template from bidder config - Append apptoken and placementid dynamically using URIBuilder - Update unit tests to verify parameter building and single-encoding behavior

Merge branch 'adding-adapter-adplayx' of https://github.com/anuraj700…

b4bf265

…/prebid-server-java into adding-adapter-adplayx

anuraj700 requested a review from CTMBNara August 15, 2026 05:50

CTMBNara requested changes Aug 19, 2026

View reviewed changes

Comment thread src/main/java/org/prebid/server/bidder/adplayx/AdplayxBidder.java Outdated

anuraj700 requested a review from CTMBNara August 20, 2026 14:11

CTMBNara requested changes Aug 25, 2026

View reviewed changes

Refactor AdplayxBidder and add integration test

362b84b

- Update URI parameter handling using Uri.of in constructor - Adopt standard stream-based bid parsing and BidderUtil.defaultRequest - Add AdplayxTest integration test suite

anuraj700 requested a review from CTMBNara September 3, 2026 04:15

CTMBNara requested changes Sep 17, 2026

View reviewed changes

Comment thread src/main/java/org/prebid/server/bidder/adplayx/AdplayxBidder.java Outdated

Update AdplayxBidder.java

9132dd1

As per review comments - resolving the excess check

anuraj700 requested a review from CTMBNara September 20, 2026 07:03

CTMBNara previously approved these changes Sep 21, 2026

View reviewed changes

fixing checkstyle

355e483

anuraj700 dismissed CTMBNara’s stale review via 355e483 September 26, 2026 09:56

osulzhenko changed the title ~~[Bidder Adapter] Add AdPlayx adapter~~ AdPlayx: New Adapter Sep 30, 2026

Fixing unit test and integration test

89d853b

CTMBNara requested changes Oct 5, 2026

View reviewed changes

Update to AdplayxBidder.java

6f8ff6c

anuraj700 requested a review from CTMBNara October 7, 2026 05:06

osulzhenko approved these changes Oct 13, 2026

View reviewed changes

CTMBNara approved these changes Oct 22, 2026

View reviewed changes

Conversation

anuraj700 commented Jul 31, 2026

Type of Change

Description

Key Changes Made:

Checklist

Testing Instructions

Uh oh!

CTMBNara left a comment

Choose a reason for hiding this comment

Uh oh!

anuraj700 commented Aug 15, 2026

Uh oh!

Uh oh!

CTMBNara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anuraj700 commented Sep 3, 2026

Uh oh!

Uh oh!

osulzhenko commented Sep 22, 2026

Uh oh!

anuraj700 commented Sep 26, 2026

Uh oh!

osulzhenko commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anuraj700 commented Oct 3, 2026

Uh oh!

CTMBNara Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

anuraj700 Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

anuraj700 commented Oct 14, 2026

Uh oh!

anuraj700 commented Oct 18, 2026

Uh oh!

anuraj700 commented Oct 22, 2026

this is still in pending state and not merged Could you please help in getting this merged

❌ TEST-org.prebid.server.functional.tests.postgres.PostgresDBSpec.xml

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

osulzhenko commented Sep 29, 2026 •

edited

Loading

this is still in pending state and not merged
Could you please help in getting this merged