Repository navigation
Docs maintenance (#5630): release notes nav, dead tool links, Prebid.js 11 cleanup - #6851
Open
patmmccann wants to merge 2 commits into
Open
patmmccann wants to merge 2 commits into
patmmccann wants to merge 2 commits into
Conversation
…bid.js 11 cleanup - Release notes: link PBS-Java, both Prebid Cache repos and the Universal Creative; add the page to the Support sidebar and the Support top-nav menu. - optimal-header-bidding-setup: Headerbid Expert no longer exists; point to Professor Prebid and the troubleshooting guide, drop its logo and the unused original screenshots. - how-many-bidders: note the study's age; fix the FAQ's dead prebid.org/blog link to it. - Pages of modules removed in Prebid.js 11 (paapi, paapiForGpt, topLevelPaapi, adpod, categoryTranslation, dfpAdpod, dfp_express, freewheel, intersectionRtdProvider) get a "removed in 11.0" banner; paapiForGpt also takes over the deleted fledgeForGpt URL. optable's Prebid.js adapter was removed in 11 (pbjs: false). - setConfig: drop the Adpod and Category Translation links; step-by-step: mark the Adpod note as 10.x and earlier; video module: gamAdServerVideo; prebidServer: seatNonBid event -> pbsAnalytics, and the basic example now includes the required endpoint/syncEndpoint. - Remove stray repo-root files (a Windows .lnk shortcut and an empty Install-Package file). - Fix markdownlint errors in the touched files. Refs prebid#5630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2cbd47c6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5630. This makes substantial progress on the issue but doesn't close it. Items that need a decision are listed at the end.
Issue items
sidebarType: 7, so the Support section expands when you're on it. The URL is unchanged, and the existing Prebid.js > Reference entry stays.optimal-header-bidding-setup.md: the Chrome Web Store listing is gone and headerbid.expert doesn't resolve. The scenario explanations are still accurate, so the page is kept. The tool references now point to Professor Prebid and the troubleshooting guide. I deleted the logo and the unusedhb-expert/Original/screenshots.how-many-bidders-for-header-bidding.mddoesn't actually mention the tool. It gets a note that the study is several years old. The FAQ's link to it pointed at a 404 (prebid.org/blog/how-many-bidders-for-header-bidding) and now points at the docs page.Prebid.js 11 cleanup on top-visited pages
I checked each of these against
modules/on master./dev-docs/modules/with no warning. These nine now get a "removed in Prebid.js 11.0" banner linking to the pb11 removed-modules table: paapi, paapiForGpt, topLevelPaapi, adpod, categoryTranslation, dfpAdpod, dfp_express, freewheel, intersectionRtdProvider.enable_downloadalone so 10.x builds still offer them. Download page: filter modules by version, explain failures, add timeouts, drop v8 handling #6842's version filter hides them for 11.x.fledgeForGpt.htmlwas deleted without a redirect and returns 404. It now redirects topaapiForGpt, its successor, which carries the banner.optable.md: setpbjs: false, since the Prebid.js adapter was removed in 11.setConfig.md: dropped the Adpod and Category Translation links from the module list.adops/step-by-step.md: the Adpod note is marked 10.x and earlier.prebid-video/video-module.md:dfpAdServerVideois nowgamAdServerVideo. The vendor code is still'gam'.prebidServer.md:seatNonBidevent was removed in 11, so the text now points topbsAnalytics(seatnonbidfield).endpoint/syncEndpoint. Both are required since host defaults were removed. It's now a minimal example with both.Other
ADS - Acceso directo.lnk, a Windows shortcut committed with an adapter doc, and an emptyInstall-Package.Still open on #5630 (needs a decision)
prebid-video/video-long-form.md,dev-docs/show-long-form-video-with-gam.md, the adpod sections ofbidder-adaptor.md, and the "Setting up Long-Form Video" sidebar entry still present Adpod as current. Options are a "Prebid.js 10.x and earlier" banner or removal. PBS long-form is separate and still valid.getPAAPIBids,getPAAPIConfigandsetPAAPIConfigForGPTstill list as current Publisher APIs. Options are deletion or a banner. Separately, PBS owners need to confirm whether the PBS "Fledge Auctions" section is still supported.features/pbAdSlot.md: pbadslot was removed in Prebid.js 10, but this top-visited page still uses it in examples. It needs a rewrite as a GPID page.dfpAdServerVideoorfledgeForGpt(ix, ampliffy, aidem). These are for the adapter maintainers._includes/left_nav.htmlmatches sections by position (forloop.index0), so reordering sections means renumberingsbSecId/sidebarTypeeverywhere. Matching on the section header's ownsbSecIdinstead would let sections be reordered insidebar.ymlwithout touching pages. That's worth a separate PR.🤖 Generated with Claude Code