Repository navigation
Timeout reporting disclosures for popular bidders - #6862
patmmccann wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5c1c91b8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add the disclosure to trustedstack, which is a Media.net alias. - Rewrite tables in the changed files to MD060 compact style. - Promote headings on amx, kargo, medianet and onetag so the first is h2 (MD001). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #3029.
Module rules list "this bidder reports timeout events" as a required disclosure, but almost no bidder page carried one. This adds a reusable disclosure and applies it to the most popular bidders (top 30 by sites on the Prebid insights dashboard) whose adapters report timeouts. It's meant as an example for other adapters, not an exhaustive pass.
New include
_includes/dev-docs/reports-timeout-events.md: a warning alert likeloads-external-javascript.md, withendpointanddataparameters: "Disclosure: This bidder reports timeout events. When it times out in an auction, the adapter sends {data} tohttps://{endpoint}."Bidder pages: added at the top of the seven whose
onTimeoutsends a request (checked against Prebid.js master):s.seedtag.com/se/hb/timeout(pixel)1x1.a-mo.net/e(POST, with credentials)onetag-sys.com/ptimeout(POST)krk2.kargo.com/api/v1/event/timeoutnavvy.media.net/lognavvy.media.net/logs.richaudience.com/err/(pixel)ms-ads-monitoring-events.presage.io/bid_timeout(POST)Checked, no disclosure needed: rubicon, pubmatic, appnexus, ix, triplelift, openx, criteo, teads, gumgum, ttd, adagio, sovrn, smilewanted, smartadserver, rtbhouse, unruly, ozone, 33across, kueez_rtb, adf and undertone have no
onTimeout. sharethrough's is an empty stub.prebid_serverisn't a bidder adapter.module-rules.md: the Disclosure section now says when the timeout disclosure applies (anonTimeoutthat sends a network request, not an empty one) and how to add it.Lint: CI's markdownlint checks whole files, so the existing tables in the touched files were rewritten to the compact table style (MD060), and the headings on amx, kargo, medianet and onetag were promoted one level so the first is h2 (MD001). No content changes.
bidder-adaptor.md: "Registering on Timeout" now says adapters that report timeouts must disclose it, linking to the module rules.Other event hooks (
onBidWon,onSetTargeting,onBidderError) can phone home too; they're out of scope here but could follow the same pattern.🤖 Generated with Claude Code