Repository navigation
Video examples: don't depend on live bidders; remove adpod examples - #6865
patmmccann wants to merge 2 commits into
Conversation
… examples Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e3ac79e61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Disable persisted debugging overrides when leaving video demos and restore the mock when returning via the back/forward cache. Update the video examples description to omit removed long-form examples. Authored with assistance from ChatGPT.
Closes #5248.
The video examples relied on the
msfttest placement bidding, which it often doesn't. On production today, with Prebid.js loaded, the outstream examples get no bid at all. Bids are now simulated with the debugging module, as the issue suggests. The shared setup lives in Jekyll includes rather than a separate JS file, following the existing_includes/video/mock-video-bid.htmlthat the instream examples already used._includes/video/mock-outstream-bid.html: intercepts every bid as a video bid withoutvastXml/vastUrl, so the debugging module supplies its demo VAST and outstream renderer. Used by:pb-os-nas(Outstream, No Server),pb-os-nas-renderer(No Server with a publisher-specified renderer; the ad unit's renderer plays the demo VAST),pb-os-dfp(Outstream with Google Ad Manager).examples/video/outstream/basic-ima.html: now includes the existingmock-video-bid.html, since it playsbid.vastXmlitself through IMA. Also removes a straysprinted after its Prebid.js include.examples/video/long-form/(both pages and their assets) and_includes/video/pb-lf-fw.htmlare deleted. Their links are removed fromexamples/video/index.mdandprebid-video/video-long-form.md. That getting-started page itself still documents adpod and may need its own cleanup.msftsetup; the mock runs only in the page header, as with the existing instream examples.Verified on the deploy preview (headless Chrome, CMP-gated scripts loaded manually)
adRenderSucceeded, no page errors.hb_pb=1.00targeting are set. Whether GAM serves the outstream creative depends on that network's line items. GPT waits for TCF consent, which I couldn't grant headlessly, so that last step is unverified.Not changed, separate issue: the Video Module (videojs) example already uses its own intercept, but sends no bid request either here or on production. Its page script configures the videojs provider before the consent-gated video.js loads.
🤖 Generated with Claude Code