Repository navigation
Conversation
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8179c399-5285-4340-bdfc-d0d00ada417f
There was a problem hiding this comment.
🟡 Changes recommended
Workflow validation errors and label-update failures prevent reliable operation.
7 open findings
Fix unterminated GitHub Actions expression · New Resolve pull requests for status events · New Allow grep no-match results in label checks · New Remove duplicate empty run key · New Close the failing-label condition expression · New Prevent grep no-match exits in failing-label checks · New Do not treat skipped checks as passing · New
What changed in this PR
Adds a status-driven alternative to comment-based integration labeling for Primer React pull requests.
Changes:
- Listens for terminal
github-uistatus events. - Aggregates matching statuses to select passing or failing labels.
| File | Description |
|---|---|
.github/workflows/integration-result.yml |
Adds status aggregation and integration-label update steps. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| passing=$(jq ' | ||
| [.[].statuses[] | select(.context | startswith("github-ui"))] | ||
| | length > 0 and all(.[]; .state == "success") |
There was a problem hiding this comment.
Added an explicit skipped/override check across the aggregated statuses and bypassed label updates when either description is present. Fixed in 8229210.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8179c399-5285-4340-bdfc-d0d00ada417f
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
|
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>


No linked issue.
Add an alternative to our check-for-integration-comment.yml workflow that applies labels based on the result of
github-uistatus checks. This uses status events instead of checking integration comments directly.The label job runs for
github-uistatus events with asuccess,failure, orerrorstate. Events with aSkippedorManual overridedescription are excluded so manual overrides do not update the integration result labels.Changelog
New
github-uistatuses and updates the passing or failing integration labels.Changed
runkey and unclosed step conditions in the workflow.statuses: readandpull-requests: writepermissions.Removed
None.
Rollout strategy
This is an internal workflow change with no public API impact. No changeset is needed.
Testing & Reviewing
npx --no-install prettier --write .github/workflows/integration-result.yml: passed.npx --no-install prettier --check .github/workflows/integration-result.yml: passed.git diff --check: passed.actionlint .github/workflows/integration-result.yml: passed.