Skip to content

Add public tooltip-only suppression - #8754

Draft
adierkens wants to merge 2 commits into
mainfrom
adierkens-tooltip-suppression
Draft

adierkens wants to merge 2 commits into
mainfrom
adierkens-tooltip-suppression

Conversation

@adierkens

@adierkens adierkens commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Relates to github/core-ux#4233.

Add public suppression to the main Tooltip API, preserving trigger behavior and accessible text. This PR is independent of trigger composition.

Changelog

New

  • Tooltip.disabled closes visible bubbles, cancels pending opens, and prevents reopening without disabling its trigger. Standard Tooltip examples demonstrate suppression and configured menu anchors.

Changed

  • Either disabled or _privateDisableTooltip being true suppresses the tooltip. Re-enabling requires fresh interaction; accessible naming/descriptions remain intact. Private suppression also closes visible bubbles, and repeated hover no longer leaves orphaned opening timers.
  • Deprecate the private alias in favor of disabled and migrate IconButton's internal tooltip suppression to the public prop; compatibility remains covered.

Removed

None. No controlled visibility, trigger-composition, or bubble-props API is introduced.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

Passed on the standalone main-based branch: npm run build, npm run type-check, npm test -- --run (3,101 tests), npm run lint:npm --workspace @primer/react, npm run lint:fix, npm run lint:css, npm run format, npm run format:diff, and git diff --check. The packaged declaration retains the deprecation pointer. Focused IconButton/Tooltip tests passed (103 tests).

Both stable stories were rendered and exercised in Chromium. Axe + GitHub checks passed settled visible-tooltip, suppressed-tooltip, and open-menu states. Manual screen-reader checks and canonical AVT/VRT were not run; the full accessibility review remains incomplete. Storybook MCP was unavailable; local browser verification was used.

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c23e8e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@adierkens
adierkens changed the base branch from adierkens-primer-trigger-composition to main November 13, 2026 21:23
@adierkens
adierkens force-pushed the adierkens-tooltip-suppression branch from e168018 to 6f247d2 Compare November 13, 2026 21:23
@adierkens adierkens changed the title Add experimental tooltip-only suppression Add public tooltip-only suppression Nov 13, 2026
@github-actions
github-actions Bot requested a deployment to storybook-preview-8754 November 13, 2026 21:28 Abandoned
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch was successfully deployed

2 active deployments
storybook-preview-8754 — c23e8e55 Deployed Nov 13, 2026 by github-actions[bot]
github-pages — c23e8e55 Deployed Nov 13, 2026 by adierkens via deploy-preview #34294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant