Repository navigation
Blankslate: graduate compact default sizing - #8757
Draft
francinelucca wants to merge 3 commits into
Draft
francinelucca wants to merge 3 commits into
francinelucca wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 400f394 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue. Follow-up to #8034.
Graduate
primer_react_blankslate_compact_defaultby making its enabled presentation unconditional. Remove the flag, legacy sizing and responsive overrides, and the now-unused internal size context. Removesize="small"completely: the supported sizes are nowmedium(default) andlarge.The default/medium presentation uses 16px padding, compact heading typography, and medium body typography. Large uses 32px padding, medium heading typography, and large body typography. Primary actions use the default medium button size in every variant. Spacious padding remains 44px/28px for medium and 80px/40px for large, including narrow containers.
Changelog
New
Changed
@primer/reactmajor changeset for the narrowed public size type.Removed
primer_react_blankslate_compact_default, its disabled presentation, and the unused internal Blankslate context.Rollout strategy
Breaking change: replace
size="small"withsize="medium"or omit the size prop. Consumers already using the flag-enabled medium/large presentation retain the same sizing. Consumers without the flag receive the compact size scale. Confirm rollout readiness and run github/github-ui integration before merging; no downstream changes were made or verified in this PR.Testing & Reviewing
npm run build— passed after removing small.npx vitest run --project '@primer/react' packages/react/src/Blankslate/Blankslate.test.tsx packages/react/src/FeatureFlags— passed, 21 tests.npm run type-check— passed after removing small.npx eslint --fix packages/react/src/Blankslate/Blankslate.tsx packages/react/src/Blankslate/Blankslate.figma.tsx packages/react/src/Blankslate/Blankslate.test.tsx packages/react/src/Blankslate/Blankslate.features.stories.tsx packages/react/src/Blankslate/Blankslate.stories.tsx e2e/components/Blankslate.test.ts— passed.npx stylelint -q --rd --fix packages/react/src/Blankslate/Blankslate.module.css— passed for graduation; CSS was unchanged by small-size removal.npm run format:diff,npm run format, andgit diff --check— passed.npx playwright test e2e/components/Blankslate.test.ts --list— passed, 81 tests discovered; size scenarios only include medium and large. This enumerated tests, not screenshot comparisons.update snapshotslabel requests canonical baseline regeneration for the newly default presentation.Review default, medium, and large across narrow/wide containers, with and without spacious padding. Confirm all primary actions retain medium button sizing and migrate any downstream small usages to medium.