Repository navigation
Graduate button loading disabled styles - #8758
Draft
francinelucca wants to merge 2 commits into
Draft
francinelucca wants to merge 2 commits into
francinelucca wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 98f955c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7879
Graduate
primer_react_button_loading_disabled_styles: loading buttons now use disabled styling by default while retaining their existingaria-disabledsemantics, focusability, and loading announcements. This preserves the primary variant without requiring nativedisabledorinactive.Changelog
New
Changed
@primer/reactpatch changeset.Removed
primer_react_button_loading_disabled_stylesregistration, hook usage, and temporary styling attribute.Rollout strategy
Ship the previously flagged styling as the default in the next patch release. No consumer API migration is required.
Testing & Reviewing
npm run build— passed.npm test -- --run --project '@primer/react' packages/react/src/Button/__tests__/Button.test.tsx— passed, 63 tests.npm test -- --run— passed, 3,094 tests; 3 skipped and 10 todo.npm run type-check— passed.npm run lintandnpm run lint:css— passed.npm run format,npm run lint:fix, andnpm run format:diff— passed.STORYBOOK_URL=http://localhost:6008 npx playwright test e2e/components/Axe.test.ts --grep 'components-(button|iconbutton|linkbutton)-features--loading( |-|$)' --workers=2— passed, 108 accessibility checks across nine themes. Used the running Storybook index for accessibility test discovery.STORYBOOK_URL=http://localhost:6008 npx playwright test e2e/components/Button.test.ts --grep 'Loading.*@vrt' --workers=2— could not compare: all 36 checks lack macOS baselines. Generated macOS snapshots were removed; canonical Linux baselines should be regenerated with theupdate snapshotslabel.Visually inspected the existing Loading story: loading primary buttons retain the primary disabled appearance and remain focusable without native
disabled.