Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ Categories used here:
`pgx5://` included). A URL whose user name, password or database name holds an unencoded `/`
or `@` that would split it in the wrong place is refused by both, with a message that names no
part of it; percent-encode those characters (`%2F`, `%40`).
- **Shipped — a strict org's served form stops at the 1 MiB limit while it is built.** Inlining
pinned modules and inserting the `__tenant_id__` drops now count every byte against the pipeline
limit as they go, so a pipeline that would expand past 1 MiB (one module imported many times,
nested imports, re-quoted module contents, many drops) is refused as too large when it reaches the
limit instead of after being built in full. A pipeline that expands more than 256 imports
(`import.git` and `import.string`, nested ones and repeats included) is refused as well. Every
pipeline whose served form fits is served byte for byte as before. A pipeline that is too large
and also has another problem (a module not fetched yet, an unpinned revision, nesting too deep)
may now be refused for its size first; fixing that shows the other problem.
- **Shipped — group access is bound to the org that granted it.** A group assigned to a
collector on its Access tab gives its members viewer access only while the collector's cluster
stays in the org that made the assignment. Claiming a cluster into another org removes the
Expand Down
12 changes: 11 additions & 1 deletion docs/spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,17 @@ every pipeline without an `import.git` block, are served byte for byte as before
change: only a strict org's pipeline that uses a pinned import is served differently). The
validation gate validates that served form too (`TenantPolicy.Inline`): Stages 1-2 and the tenant
lint on the inlined text, refused when it cannot be built or is over the 1 MiB pipeline cap
(`validate.MaxContentBytes`); role/signal enforcement and the editor's derived signals see it as
(`validate.MaxContentBytes`). The cap holds while the form is built, not only after: each level (the
pipeline, each module, each literal `import.string` content) is inlined and given its drops in one
pass (`validate.BuildServedLevel`), so no intermediate text is built, and one byte budget
(`validate.ServedBudget`) is charged for every module text, nested expansion, re-quoted content and
inserted drop before it is built; the build stops the moment the result would pass 1 MiB. What is
charged never exceeds the finished length (a content literal written with escapes the encoder does
not use can re-quote shorter, which is why no intermediate is charged), so a pipeline whose served
form fits is built byte for byte as before. A pipeline that expands more than 256 imports
(`pinnedimport.MaxImportInstances`: `import.git` and `import.string` blocks, nested ones and repeats
included) is refused too. A module imported several times is read and inlined once per build, and
the tenant lint parses each module text once per run; role/signal enforcement and the editor's derived signals see it as
well, so a pinned module's declare body's signals count (an `import.git` instance would be Unknown).
At serve time an `import.git` that cannot be inlined fails the recompute closed: the collector keeps
its last good config and the failure is recorded (`last_failed_seq`, audited), never the raw import.
Expand Down
Loading
Loading