Repository navigation
Episode comments, spoiler hiding and timed reactions - #66
Closed
professorDeveloper wants to merge 3 commits into
Closed
professorDeveloper wants to merge 3 commits into
professorDeveloper wants to merge 3 commits into
Conversation
The player gets React and Comments buttons. Comments opens the episode's own thread (side panel on landscape, TV and desktop, bottom sheet on a portrait phone). React opens an eight-emoji bar with a short text option and posts at the current second. Other viewers' reactions pop up in a lane at the start edge, grouped and capped at three on screen, with a heatmap strip over the seek bar. Both can be turned off in player settings. Comments can be marked as spoilers and are blurred until tapped. A new setting, on by default, also blurs comments about episodes the viewer has not finished, using watch history. The episode list shows a comment count per episode when there are any. Title-level comments, and apps without this change, behave as before.
An is-check does not promote CommentsRepository to an unrelated interface, so the scoped calls did not resolve.
Jumping from 10 s to 13 s in one tick is a seek, which correctly restarts the window.
Owner
Author
|
Combined into one PR against release/3.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs professorDeveloper/sozo-backend#79. Until that is deployed, the new calls fail quietly and everything behaves as before.
Episode discussion
CommentsPanel. It is a side panel on landscape, TV and desktop, and a bottom sheet on a portrait phone.e<episode number>: the same number watch history uses (EpisodeKey).GET /comments/episode-countscall, and tapping the count opens that episode's thread.Spoilers
Timed reactions
How it fits in
player_page.reactions.dart. The other player files get one-line hooks: reset, load and tick next to the AniSkip calls, the layers in the stack, and the heatmap in the seek bar.EpisodeCommentsRepositoryinterface, whichCommentsRepositoryImplalso implements. Existing fakes ofCommentsRepositorykeep compiling.CommentEntitygains optional fields with defaults.comment_card.dartis not touched: the blur wraps the card from the panel.Strings
15 new keys, translated into all 16 locales.
Tests
test/features/comments/reaction_scheduler_test.dartcovers:test/features/comments/episode_key_test.dartcovers episode key building and its agreement with the history storage key.test/features/comments/spoiler_rules_test.dartcovers the visibility rules and what counts as a finished episode.Not verified
reactionreports, but the aggregated GET carries no ids.