Skip to content

test(dbbackup): discover tests never write to the real backup folder #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Oct 17, 2026
Merged

test(dbbackup): discover tests never write to the real backup folder #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/plugin-dbbackup/src/discover.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ function sandbox() {
registry.register(createDbBackupPlugin())
const settings = registry.settingsFor('dbbackup')
void settings.set('sqliteRoots', root)
// Never the default ~/Backups/diskpush: a test must not leave fake dumps where real ones go.
void settings.set('backupDir', backups)
const env = { PATH: `${bin}:/usr/bin:/bin`, HOME: process.env.HOME }
const servers: ServerDirectory = {
list: async () => [{ name: 'dev2', host: 'dev2.example', port: 22, username: 'root', keyPath: null, jumpHost: null, sshConfigAlias: null, passwordAuth: false }],
Expand Down
Loading