Repository navigation
fix(ssh): trust ~/.ssh/known_hosts too (v0.16.3) - #72
Merged
Merged
Conversation
…t 'unknown' (v0.16.3) SshSession only read DiskPush's own known_hosts, so `diskpush fleet run` called every server OpenSSH already trusted 'not in known_hosts' unless --accept-new was passed. It now also reads ~/.ssh/known_hosts (hashed entries included) read-only; newly trusted keys are still written to DiskPush's own file. Fixes #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71.
SshSessionread only DiskPush's own known_hosts, sofleet run,ls, the TUI and desktop treated every host OpenSSH already trusts as unknown. It now also reads~/.ssh/known_hostsread-only (newtrustedKnownHostsPathsoption, default that file; hashed entries were already supported). Newly accepted keys still go to DiskPush's own file.Verified: with an empty
DISKPUSH_HOMEand no--accept-new,fleet run --on dev2,dev3,devchovy,bbs-rootsucceeds on all 4 (it failed on all 4 before).pnpm test: 933/934; the one failure is the live rsync permissions test, which needs umask 022 (this box is 007). Bumps to 0.16.3.🤖 Generated with Claude Code