Repository navigation
fix(web): every playback path goes through @profullstack/player (0.45.4) - #298
Merged
Merged
Conversation
- web/radio.html #audio: was a bare .src assignment; now attachSource (native controls kept, session/key query and cookies unchanged). - backtoschool event "Listen live" <audio src>: now attachSource from data-src, destroyed on route change. - web intro jingle (new Audio().src): now attachSource. - Inline /station fallback (served only without the web build): its own <audio>/<video> player is gone; Play hands the station to an external player via listen.m3u. The built station page already uses createPlayer. - @profullstack/player pinned to 0.15.0 in web and backtoschool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standing rule: every audio/video player on the fleet is @profullstack/player.
#video/#audio(web/src/player.ts)<audio controls>(web/src/radio.ts)audio.src = ...?session=/?k=query and cookies kept<audio id="event-audio" src>srcattributedata-src; destroyed on route changenew Audio().src = ...new Audio()/<video id="screen">bun run web:build@profullstack/playerpinned to exactly0.15.0in web and backtoschool (bun.lock checked).bun run typecheck,bun test test web/test(985 pass, 0 fail), web + backtoschool + tsc builds all pass locally.🤖 Generated with Claude Code