Skip to content

fix(web): every playback path goes through @profullstack/player (0.45.4) - #298

Merged
ralyodio merged 1 commit into
mainfrom
fix/player-everywhere
Oct 19, 2026
Merged

ralyodio merged 1 commit into
mainfrom
fix/player-everywhere

Conversation

@ralyodio

Copy link
Copy Markdown
Contributor

Standing rule: every audio/video player on the fleet is @profullstack/player.

Path Before After
web/index.html #video/#audio (web/src/player.ts) attachSource unchanged
web/station.html, web/watch.html createPlayer unchanged
backtoschool/src/player.ts (classroom video) attachSource unchanged
web/radio.html <audio controls> (web/src/radio.ts) audio.src = ... attachSource, kind audio; native controls, ?session=/?k= query and cookies kept
backtoschool event page <audio id="event-audio" src> raw src attribute attachSource from data-src; destroyed on route change
web intro jingle (app.ts) new Audio().src = ... attachSource, still routed through Player.playJingle for the spectrum
src/station-page.ts inline fallback (only served when web/dist/station.html is missing; every live server serves the built page) own new Audio() / <video id="screen"> no media element; Play opens listen.m3u in the listener's player, note to run bun run web:build
  • @profullstack/player pinned to exactly 0.15.0 in web and backtoschool (bun.lock checked).
  • No direct hls.js/mpegts.js dependency existed; both only come in through the player.
  • bun run typecheck, bun test test web/test (985 pass, 0 fail), web + backtoschool + tsc builds all pass locally.

🤖 Generated with Claude Code

- web/radio.html #audio: was a bare .src assignment; now attachSource
  (native controls kept, session/key query and cookies unchanged).
- backtoschool event "Listen live" <audio src>: now attachSource from
  data-src, destroyed on route change.
- web intro jingle (new Audio().src): now attachSource.
- Inline /station fallback (served only without the web build): its own
  <audio>/<video> player is gone; Play hands the station to an external
  player via listen.m3u. The built station page already uses createPlayer.
- @profullstack/player pinned to 0.15.0 in web and backtoschool.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​profullstack/​footer@​0.2.1 ⏵ 0.2.578 +4100100 +194 +5100
Updated@​profullstack/​player@​0.13.2 ⏵ 0.15.078 +2100100 +196 +1100

View full report

@ralyodio
ralyodio merged commit 05b0e9b into main Oct 19, 2026
4 checks passed
@ralyodio ralyodio mentioned this pull request Oct 19, 2026
ralyodio added a commit that referenced this pull request Oct 19, 2026
…298) (#300)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@ralyodio
ralyodio deleted the fix/player-everywhere branch October 19, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant