Repository navigation
Signed-in listeners skip station breaks outright, no silence (0.46.1) - #303
Merged
Merged
Conversation
…0.46.1) A pass holder now gets the last two minutes of break-free music at once and then the live stream with break bytes left out; each skipped spot spends its length of that head start, so the player never hears a gap. Silence is only the fallback once the head start is spent (about 24 breaks), and a rejoin refills it. Break detection for radio lists is now from the CBR output byte count (to the frame) instead of once-a-second progress. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthony: "don't go silent just don't play the ad at all".
A live stream can't skip ahead, so a pass holder starts up to two minutes behind live:
Channel.listenWithoutBreakshands them the last ~2 min of break-free music at once (their player buffers it), then the live stream minus break bytes. Each skipped spot spends its length of that head start, so there is no gap. Silence (break-silence.ts) is only the fallback once ~24 breaks have used it all; a rejoin refills it. The station page already delays now-playing titles by what the player holds.Break detection for radio lists now comes from the CBR output byte count (frame-accurate) instead of once-a-second ffmpeg progress.
Tests: new channel test in test/listen-pass.test.ts; full suite 992 pass / 0 fail.
🤖 Generated with Claude Code