The feed page heading, which the title polish missed - #160
Merged
Conversation
#159 gave a social row its canonical name in the RSS channel title and in the page metadata, and left the thing a reader actually looks at — the <h1> — saying "reddit.com". The cause was one line away from the change: `FEED_COLS` does not select `social_ref`, so `feedBySlug` has never returned it and the feed page could not tell a social row from any other. The RSS path worked only because it goes through `feedBySocialRef`, which is `select *`. So the columns join FEED_COLS, and the page uses them. Both addresses for a row now agree — /r/programming and /r-programming show the same name — which they did not before, since only one of them knew what it was holding. Verified against a seeded database rather than by reading: a row titled "reddit.com", exactly as the OPML import leaves them, now renders "r/programming" in the heading, the <title> and the feed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6QEgpuS4MLamogXtr2ZX6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#159 gave a social row its canonical name in the RSS channel title and in the page metadata, and left the thing a reader actually looks at — the
<h1>— saying "reddit.com".I caught it verifying #159 in production, not before merging it.
Cause
One line away from the change:
FEED_COLSdoes not selectsocial_ref, sofeedBySlughas never returned it and the feed page could not tell a social row from any other. The RSS path worked only because it goes throughfeedBySocialRef, which isselect *.So the social columns join
FEED_COLS, and the page uses them.A side effect worth naming: both addresses for a row now agree.
/r/programmingand/r-programmingrender the same name, which they did not before — only one of them knew what it was holding.Verified, not inspected
Against a seeded database with a row titled
reddit.com, exactly as the OPML import leaves them:/r/programming<h1>/r-programming<h1><title>.rsschannel title1,345 tests green, build clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q6QEgpuS4MLamogXtr2ZX6