Skip to content

fix(cli): ignore string braces when editing targets - #1004

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
hamedrabah:fix-target-config-brace-parsing
Aug 31, 2026
Merged

fix(cli): ignore string braces when editing targets#1004
ralyodio merged 1 commit into
profullstack:masterfrom
hamedrabah:fix-target-config-brace-parsing

Conversation

@hamedrabah

Copy link
Copy Markdown
Contributor

Summary

  • mask string and comment contents before locating the targets object boundary
  • keep newly added targets at the top level when existing config values contain braces
  • add a regression test that reloads the edited manifest and verifies the target is enabled

Tests

  • pnpm exec vitest run packages/cli/src/commands/ship.test.ts
  • pnpm --filter @profullstack/sh1pt typecheck

@ralyodio
ralyodio merged commit 645e8d7 into profullstack:master Aug 31, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants