Repository navigation
fix(search): actually move stock-engine profiles to pit.world - #143
Merged
Merged
Conversation
3.17.0 only replaced an engine the launcher had set itself, so a profile on one of Chromium's stock engines (Ecosia from the choice screen, Google, Bing) kept it, and .tron-search was still written as pit, so it never retried. pit.world then never showed in chrome://settings/searchEngines either, since Chromium only adds the default to that list. - A one-time pass (.tron-search-stock) also replaces a stock engine nobody edited (prepopulate_id > 0, safe_for_autoreplace). Edited engines, engines the user added, and `tron search <x>` are still left alone. - Clear default_search_provider.guid and rewrite the mirrored copy: Chromium otherwise re-selects the old engine from Web Data by that guid. - Skip while the profile is open (SingletonLock -> live pid): Chromium rewrites Preferences on exit and the edit would be lost. Marks are written only after the edit actually lands. Checked against a copy of a real Ecosia profile on Chromium 152: pit.world becomes the default and is added to the keywords table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 25 | LOW: 21
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pit.world wasn't the default, and didn't appear in
chrome://settings/searchEngines, on profiles whose default was one of Chromium's stock engines (Ecosia, Google, Bing). 3.17.0 only replaced engines the launcher had set itself, then recorded the switch as done anyway..tron-search-stock) also replaces a stock engine nobody edited (prepopulate_id > 0and stillsafe_for_autoreplace). Edited engines, engines the user added, andtron search <x>are still left alone.default_search_provider.guidand rewrites the mirrored copy. Otherwise Chromium re-selects the old engine from Web Data by that guid.Preferenceson exit. Marks are written only once the edit has landed.Tests: 4 new launcher tests, 44/44 pass. Checked on Chromium 152 with a copy of a real Ecosia profile: pit.world becomes the default and is added to the engines list.
🤖 Generated with Claude Code