Repository navigation
feat(profile): shared signup profile fields via @profullstack/profile - #168
Merged
Merged
Conversation
Email signup now asks for first_name and last_name (required) plus company_domain, job_title and linkedin_url (optional). The static login page gets the package's own markup from /api/v1/profile/signup-fields.js (CSP allows no inline script) and shows it only when Sign up is pressed; Log in and CoinPay never ask. POST /api/auth/signup validates before creating the user and saves into user_profiles after (never fatal). GET/PUT/PATCH /api/v1/me/profile are the package's handlers. Migration 0008 in both editions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * script (the CSP allows no inline script) that writes the package's own | ||
| * markup into #signup-fields. | ||
| */ | ||
| export const SIGNUP_FIELDS_SCRIPT = `(()=>{const el=document.getElementById('signup-fields');if(el)el.innerHTML=${JSON.stringify( |
Contributor
ThreatCrush Security Scan50 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 27 | LOW: 21
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts
@profullstack/profile@0.1.3(exact, pnpm 9.12 lockfile) in@tronbrowser/api.login.html, static): first press of Sign up reveals the package'srenderProfileFieldsmarkup (first/last name required; company domain, job title, LinkedIn optional), served by the API as/api/v1/profile/signup-fields.jsbecause the CSP allows no inline script. Log in and CoinPay never ask for them.POST /api/auth/signuprunsvalidateProfilebeforecreateUser(400 witherrors, fields markedaria-invalid), thensaveSignupProfileafter (logged, never fatal).0008_user_profiles.sqlinmigrations-pg/(with the required header; applied by start.sh at boot) and the legacymigrations/. No backfill:usershas no name column.GET/PUT/PATCH /api/v1/me/profile(package handlers, session/bearer user fromcurrentUser). CoinPay-created accounts fill it here.services/api/src/profile.test.ts(validation, save into a real in-memory SQLiteuser_profiles, 401/GET/PATCH). API suite 111/111, typecheck clean.🤖 Generated with Claude Code