Repository navigation
Add parallel pull for docker images for testcontainers - #176
Merged
Merged
Conversation
thescouser89
approved these changes
Nov 10, 2026
| base="${RUNNER_TEMP}/pre-pull/$((++n))" | ||
| echo "${image}" > "${base}.log" | ||
| # shellcheck disable=SC2016 | ||
| setsid bash -c 'docker pull -- "$1" >> "$2.log" 2>&1; echo "$? ${SECONDS}" > "$2.rc"' _ "${image}" "${base}" > /dev/null 2>&1 < /dev/null & |
Contributor
There was a problem hiding this comment.
Why do we need the setsid thing? Just curious about it.
Member
Author
There was a problem hiding this comment.
setsid starts the pull in its own session and process group, so it is detached from the step's shell. This allows it do the pull while the build runs in parallel - so by the time orch gets to e.g. the integration-test-rex, the pull will already have been done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/entur/gha-testcontainers but that doesn't support just passing a String list of image names.