Repository navigation
Fix connection leaks when requests fail - #544
Merged
Mzack9999 merged 2 commits intoOct 23, 2026
Merged
Conversation
Mzack9999
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547
I run Live Tennis API.
Request write errors, response parse errors and invalid gzip responses leave the connection open. The caller receives no response body to close.
Close the connection on each failure and preserve the original error if cleanup also fails. Successful responses keep their connection until Response.Body.Close.
The regressions cover all three error paths with successful and failed cleanup. A separate test checks successful body ownership.
Go 1.24.1 passes
go test -modfile="$modfile" -v -race ./...,go vet -modfile="$modfile" ./...andgo build -modfile="$modfile" ./....The CI example returns fifty HTTP 200 responses.
golangci-lint run --timeout 5mpasses with version 1.64.8.The temporary module file raises the Go directive to 1.22.0. Untouched upstream also needs this adjustment. Dependency versions and tracked module files are unchanged.